Adding more custom dialogs: Error dialog#203
Open
int-0 wants to merge 4 commits intorawpython:masterfrom
Open
Conversation
Collaborator
|
Thank you a lot @int-0 ! You made a really good work. I haven't yet tested the code, but however appears to be good code. And you surprised me with the artwork :D |
Collaborator
|
@int-0 I merged your code in branch "int-0_dialogs". I like the code you wrote and I will merge it in master branch. Just one question: why you haven't used GenericDialog as base class? |
Collaborator
|
@int-0 You are making really good code, but I would ask you to make different pull reqs for different functionalities. This will allow a simpler review of the code. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm using your amazing python library 👍
I write some custom dialogs... in this pull request only "Error" dialog is added but I'm going to create several more...
I'm glad to sending you this pull request I've been working on. You can use if you wish and it could be nice if you send any feedback.
Thank you and thank for your awesome work!